Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tigervnc: update to 1.13.1, add service directory #45307

Closed
wants to merge 1 commit into from
Closed

tigervnc: update to 1.13.1, add service directory #45307

wants to merge 1 commit into from

Conversation

zmudc
Copy link

@zmudc zmudc commented Jul 29, 2023 •
edited
Loading

In addition to updating to the latest version, this commit also fixes multiple issues with this package:

  • Upstream only provides a systemd service, but Void needs a runit service
  • Upstream presumes a system with SELinux and systemd, but Void does not have SELinux and uses elogind, not systemd
  • Upstream requires an Xsession script that is not always present on Void systems
  • Upstream only provides a forking and detaching vncsession daemon which is not very compatible with runit

This PR addresses all of the above issues by adding the necessary tweaks for Void:

  • Void-compatible PAM configuration for systems without SELinux and elogind instead of systemd
  • a fallback Xsession wrapper script
  • define conf_files that should not be overwritten on upgrades
  • add a README.voidlinux file
  • patch vncsession.c to provide an option to prevent it from forking
  • patch vncsession-start.in to use the option to prevent vncsession from forking

The patch to vncsession.c hopefully will be accepted upstream to fix upstream issue: TigerVNC/tigervnc#1649. The patch has been submitted to upstream as TigerVNC/tigervnc#1651

Closes #45522

Testing the changes

  • I tested the changes in this PR: YES Tested on x86_64-musl, also built for x86_64, checked xlint which passed

classabbyamp
classabbyamp reviewed Jul 29, 2023
View reviewed changes
srcpkgs/tigervnc/files/vncserver-1/log/run Outdated Show resolved Hide resolved
srcpkgs/tigervnc/files/vncserver-1/run Outdated Show resolved Hide resolved
srcpkgs/tigervnc/files/vncserver-1/run Outdated Show resolved Hide resolved
srcpkgs/tigervnc/files/vncserver-1/run Outdated Show resolved Hide resolved
srcpkgs/tigervnc/template Outdated Show resolved Hide resolved
srcpkgs/tigervnc/template Outdated Show resolved Hide resolved
srcpkgs/tigervnc/template Outdated Show resolved Hide resolved
srcpkgs/tigervnc/template Outdated Show resolved Hide resolved
@zmudc
Copy link
Author

zmudc commented Jul 29, 2023

I forget to mention cross compiling for armv7l also tested successfully.

@zmudc
Copy link
Author

zmudc commented Jul 30, 2023 •
edited
Loading

The updated PR has been tested and is ready to be reviewed for the second round. I think it addresses all of the concerns of @classabbyamp. Sorry about the noise but I think the PR is OK now - it has one commit and it has fixed a typo in README.voidlinux

Thanks.

Also, note that the e-mail address to which github sent messages for this PR does not match the e-mail address I put in the commit message. I haven't figured out how to fix that yet. I wanted github to use the [email protected] address, and I set my public address to that address and used that address in the commit message, but github for some reason sent the comments to my other email address associated with my github account: [email protected]. I think it is because there were more email settings I had to update. Hopefully it is fixed now. Sorry about that.

@zmudc
tigervnc: update to 1.13.1, add service directory
c2ea9a1 
Also add necessary customizations:
    - Void-compatible PAM configuration
    - fallback Xsession wrapper script
    - define conf_files
    - README.voidlinux file
    - patch vncsession.c to prevent it from forking

The patch to vncsession.c hopefully will be accepted upstream to fix
upstream issue TigerVNC/tigervnc#1649

Signed-off-by: Chuck Zmudzinski <[email protected]>
@zmudc
Copy link
Author

zmudc commented Aug 1, 2023

This last push just corrected a typo in README.voidlinux - there was a repeated word. Prior to this, all eight tests passed.

@zmudc zmudc mentioned this pull request Aug 10, 2023
Closed
@ahesford
Copy link
Member

We won't accept the non-daemonize patch until it's accepted upstream.

@zmudc
Copy link
Author

zmudc commented Aug 17, 2023 •
edited
Loading

We won't accept the non-daemonize patch until it's accepted upstream.

OK. I doubt upstream will take it. So I will close this now and re-submit a PR if upstream takes the non-daemonize patch. Thanks.

@zmudc zmudc closed this Aug 17, 2023
@zmudc zmudc mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classabbyamp classabbyamp classabbyamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tigervnc: a working runit service for the tigervnc vncserver cannot be written
3 participants
@zmudc @ahesford @classabbyamp